Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 build: Relabel manylinux wheel ignoring pyarrow #14

Merged
merged 4 commits into from
Feb 26, 2023
Merged

Conversation

rdbisme
Copy link
Collaborator

@rdbisme rdbisme commented Feb 21, 2023

No description provided.

@rdbisme rdbisme mentioned this pull request Feb 21, 2023
Closed
7 tasks
@rdbisme
Copy link
Collaborator Author

rdbisme commented Feb 21, 2023

Probably I'd replace the repair-wheel script with a Python script, getting the libraries dynamically using pa.get_libraries() and the version from pa.__version__ to build the ignore list.

@rdbisme
Copy link
Collaborator Author

rdbisme commented Feb 21, 2023

@0x0L
Copy link
Owner

0x0L commented Feb 24, 2023

Should I merge as is or do you want to add so code to inject your patch in repairwheel ?

@rdbisme
Copy link
Collaborator Author

rdbisme commented Feb 24, 2023

I want to make the repairwheel independent of pyarrow version. I also opened a MR on auditwheel to support fnmatch... I'll merge once done.

@rdbisme rdbisme force-pushed the manylinux branch 2 times, most recently from 3e1880a to 9531dac Compare February 26, 2023 12:16
@rdbisme rdbisme merged commit 1bb8369 into main Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants